Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin toolchain #660

Closed
0xaatif opened this issue Sep 25, 2024 · 5 comments · Fixed by #665
Closed

pin toolchain #660

0xaatif opened this issue Sep 25, 2024 · 5 comments · Fixed by #665
Milestone

Comments

@0xaatif
Copy link
Contributor

0xaatif commented Sep 25, 2024

WIBNI reproducible CI

https://github.com/0xPolygonZero/zk_evm/actions/runs/11017223235/job/30594596343

Here we fail on the default branch due to a compiler regression

@0xaatif
Copy link
Contributor Author

0xaatif commented Sep 25, 2024

Note we already do this for mdbook, not sure what the best upgrade strategy for this is (I don't think dependabot can handle it just yet)

Could do a weekly cron-ed PR

@Nashtare
Copy link
Collaborator

Could do a weekly cron-ed PR

If we want to pin the toolchain (which may very well needed given latest mdbook issues and possibly unforeseen incoming ones), then I'd tend to opt for some cron-ed job to keep it relatively up-to-date, at least while we're heavily developing, but this seems tedious if we cannot automate the actual version bump.

@Nashtare Nashtare added this to the x Misc. milestone Sep 26, 2024
@0xaatif
Copy link
Contributor Author

0xaatif commented Sep 26, 2024

Would save us from rust-lang/rust-clippy#13458
which is blocking #659 and #564

@0xaatif
Copy link
Contributor Author

0xaatif commented Sep 26, 2024

Would save us from rust-lang/rust-clippy#13458 which is blocking #659 and #564

$ git show --pretty=reference --no-patch
56e7d08e (feat: trie diff tool (#630), 2024-09-24)

$ for day in 25 26; do
>    toolchain=nightly-2024-09-$day
>    rustup install $toolchain &>/dev/null
>    echo $toolchain
>    CARGO_TARGET_DIR=target.$toolchain.ignoreme cargo +$toolchain clippy --all-targets --quiet
> done
nightly-2024-09-25
nightly-2024-09-26
warning: unneeded `return` statement
...

@0xaatif
Copy link
Contributor Author

0xaatif commented Sep 26, 2024

(I promise I didn't break clippy to push this issue, despite the suspicious timing :D)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants