Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking CLI improvements #39

Open
bobbinth opened this issue Dec 21, 2022 · 2 comments
Open

Benchmarking CLI improvements #39

bobbinth opened this issue Dec 21, 2022 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@bobbinth
Copy link
Contributor

A few small things that would be great to improve in benchmarking CLI:

  1. We should use structop instead of clap as thats what we use for all other CLIs (e.g., here).
  2. We should keep CLI parameters as consistent as possible across different CLIs (e.g., for how we specify security, number of outputs etc.). See example here.
  3. Let's change the executable file name to something like miden-bench (miden-benchmarking-cli is way too long).
  4. miden::prove() also includes execution time, I believe. So, to make things more clear, we should probably label it as "Execution + proving time" or something like that.
  5. Would also be great to print out proof size.
@Dominik1999
Copy link
Contributor

Should we revive the CLI benchmarking? Did you use this or are you mostly using the benchmarking of the examples in the Miden VM?

@bobbinth
Copy link
Contributor Author

bobbinth commented Jun 3, 2024

I think it would be good to do so - but fairly low priority. So, maybe we can delegate this to someone external?

@Dominik1999 Dominik1999 added the good first issue Good for newcomers label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants