Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rendering erros in the Miden Assembly Instruction tab #199

Open
Dominik1999 opened this issue Sep 11, 2024 · 0 comments
Open

Fix the rendering erros in the Miden Assembly Instruction tab #199

Dominik1999 opened this issue Sep 11, 2024 · 0 comments

Comments

@Dominik1999
Copy link
Contributor

In the Miden Playground (playground.miden.io) we have the Instructions tab. There are multiple formatting errors in the table. Our ideal state is that we show all Assembly instructions from the Miden VM docs in the same cool way as EVM codes.

  1. The description of some instructions is not rendered correctly:
    Screenshot 2024-09-11 at 18 10 55

  2. For some instructions, there should be a new line if two different ways are described, e.g., adv.push_mapval and adv.push_mapval.s is the same instruction (must be in the same row), but one is a short cut for adv.push_mapval s
    Screenshot 2024-09-11 at 18 13 57

  3. I don't know if all the instructions are there. We should scan the following folders Assembly Instructions. Then, when we find a table with instructions we should add it to the JSON here. There is already a file that does that, but I am not sure it catches all the instructions, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant