Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate private keys from the rest of the config #52

Open
norswap opened this issue Sep 27, 2023 · 2 comments
Open

Separate private keys from the rest of the config #52

norswap opened this issue Sep 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@norswap
Copy link
Member

norswap commented Sep 27, 2023

Currently, we have a bunch of configuration options for accounts and private key.

This is super redundant: the accounts can be derived from the private keys, and by default we should do this derivation.

We can still allow accounts to be specified as a safety option, in which case, we will verify that the account & key match.

To do this we should install & use the eth_account python package.

@norswap norswap added the enhancement New feature or request label Sep 27, 2023
@norswap norswap self-assigned this Sep 27, 2023
@norswap
Copy link
Member Author

norswap commented Nov 30, 2023

@norswap
Copy link
Member Author

norswap commented Dec 12, 2023

It honestly might be a good idea to write the accounts explicitly, but to check the private keys against the supplied accounts, to avoid errors. Also the private keys should probably be providable separately from the config file (probably via environment variables? a secrets.toml file?) so that they do not get mingled to the config file, which should be commitable.

I'm changing the title of this issue to reflect this.

@norswap norswap changed the title Derive accounts from keys Separate private keys from the rest of the config Dec 12, 2023
@norswap norswap removed their assignment Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant