Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate deploy config against run config #51

Open
norswap opened this issue Sep 27, 2023 · 0 comments
Open

Validate deploy config against run config #51

norswap opened this issue Sep 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@norswap
Copy link
Member

norswap commented Sep 27, 2023

Roll-op enables you to deploy a rollup (create the genesis file & deploy contracts to L1) and only run it later.

However, since that's two separate commands, you could in theory specify conflicting options to bot. We should store the deploy config (= config specified for deploy) and validate the run config (= config specified to run the rollup) are consistent.

These two configs are allowed to be different! e.g. changing your mind on which ports to bind should affect anything, however, there are options that might be more problematic (TODO: which ones??)

Bonus: currently we don't regenerate the L2 genesis if it exists. We probably always should regenerate it, to avoid the same kind of issue.

@norswap norswap added the enhancement New feature or request label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant