Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.6.3 is incompatible with pyzmq 23.0.0 #251

Closed
chombourger opened this issue May 19, 2022 · 1 comment · May be fixed by #252
Closed

v0.6.3 is incompatible with pyzmq 23.0.0 #251

chombourger opened this issue May 19, 2022 · 1 comment · May be fixed by #252

Comments

@chombourger
Copy link
Contributor

The pyzmq project has recently released 23.0.0

One of the changes highlighted in the release notes is:

all zmq constants are now available as Python enums (e.g. zmq.SocketType.PULL, zmq.SocketOption.IDENTITY), generated statically from zmq.h instead of at compile-time. This means that checks for the presence of a constant (hasattr(zmq, 'RADIO')) is not a valid check for the presence of a feature. This practice has never been robust, but it may have worked sometimes. Use direct checks via e.g. zmq.has() or zmq.zmq_version_info().

I am getting errors like this one when running against that release

AttributeError: module 'zerorpc.gevent_zmq' has no attribute 'PUSH'
@chombourger chombourger mentioned this issue May 19, 2022
Closed
chombourger added a commit to chombourger/zerorpc-python that referenced this issue May 19, 2022
@chombourger
gevent_zmq: import enums from pyzmq >= 23.0.0
a95ad52 
With pyzmq 23.0.0, constants were changed to enums and moved to the
constants module. Attempt to import all globals from it into our zmq
wrapper.

Closes: 0rpc#251
Signed-off-by: Cedric Hombourger <[email protected]>
chombourger added a commit to chombourger/zerorpc-python that referenced this issue May 19, 2022
@chombourger
gevent_zmq: import enums from pyzmq >= 23.0.0
dd6843c 
With pyzmq 23.0.0, constants were changed to enums and moved to the
constants module. Attempt to import all globals from it into our zmq
wrapper.

Closes: 0rpc#251
Signed-off-by: Cedric Hombourger <[email protected]>
@chombourger chombourger mentioned this issue May 19, 2022
Open
@chew01 chew01 mentioned this issue May 24, 2022
Closed
4 tasks
@beenje beenje mentioned this issue Jun 1, 2022
Merged
5 tasks
@minrk
Copy link

minrk commented Jun 4, 2022

The constants removal from zmq.green was a bug in 23.0, now fixed in 23.1. Feel free to report any compatibility issues upstream!

beenje added a commit to beenje/zerorpc-python-feedstock that referenced this issue Jun 6, 2022
@beenje
Exclude pyzmq 23.0.0
327b5cc 
See 0rpc/zerorpc-python#251
Was fixed with pyzmq 23.1.0
@beenje beenje mentioned this issue Jun 6, 2022
Merged
4 tasks
@bombela bombela closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gevent_zmq: import enums from pyzmq >= 23.0.0 chombourger/zerorpc-python
3 participants
@chombourger @minrk @bombela