-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can you please bump this to a supported version of Electron? #108
Comments
Zeromq is also finally bumping: zeromq/zeromq.js#330 |
Can you make a pull request? After that I can release a new version. |
Yeah, I'll try to get to it sometime later this week, thanks! |
Hi is there any update on the bump new electron version? |
Yeah, I was finding that the new zeromq wasn't actually reporting being compiled against a new Electron and I got stuck, haven't returned to it yet, you're welcome to give it a shot: zeromq/zeromq.js#330 |
Previously I was using the
|
Yeah, I'm Python 3, but it's good to hear it's working for you. Are you doing |
Yes, definitely |
Well, this is still highly of interest to me because right now I haven't been able to get a working environment with both a currently-supported Electron and a currently-supported Python, so I'm glad to know there are others interested in it. |
I'm with Intelliji and created the virtual env based on python2.
as I states cause this seems been the compatible version for both node+python |
I haven't written Python 2 code in years now and it goes unsupported in a matter of weeks, so that's not a great solution, though... |
YES definitely not. |
Sorry for jumping in, but several days of research have led me to this thread. The latest zerorpc 0.9.8 installs zeromq 4.6.0, which is from 2 years ago, and that version of zeromq will not rebuild via Interestingly, when installed alone (using npm, without zerorpc), zeromq defaults to a much later 6.0.0-beta.5 version which can be rebuilt OK with electron-rebuild in the latest electron 7 (node 12 internally). But as soon as you I thought this was an electron-builder problem and documented a really simple 4 step repro case electron/rebuild#343 but was told it was not an electron builder problem. I'm starting to think it is a zerorpc problem, and that this thread is now the epicentre of an issue that has generated over a dozen unresolved forum posts and is affecting many devs. Am I on the right track? |
Correct and welcome 🙂 This is in fact why I'm still using electron 3 for my apps. |
Just let you guys know, here with Electron 6.1.5 and zerorpc 0.9.8 works well in Mac |
Yeah, the issue is that electron-rebuild doesn't seem able to work on zeromq on Windows, so if you're supporting a cross-platform app, the only solution is bumping zerorpc to require newer zeromq builds, which is what I intended to do, but the new builds aren't declaring compatibility with new electron the way they're supposed to. |
ok, I see, so electron 3 in win works fine with current zerorpc & rebuild? |
@o1xhack Yes, just built a new release of my Print42 app for windows yesterday with that combo - no probs. Yesterday I emailed the [email protected] letting them know about this thread and asking for assistance - you never know, perhaps the gurus of zeromq might help out. |
Does zeromq 6 beta fixes most of the problems? zeromq 6.0.0-beta.6 just came out. I wonder if it is reasonable to depend on the beta version. |
Unfortunately, it still doesn't ship prebuilt libraries that are compatible with a supported Electron, and it doesn't compile properly on Windows with electron-rebuild. @rolftimmermans, are you aware of this on the zeromq side? It would be trivial to add a PR to zerorpc that requires the newest zeromq, (see axfelix@0539fb1), but I can't get a good build. I wonder if just merging this commit into this repo would be worthwhile anyway, since right now it won't install anything close to a supported electron version from upstream... |
Hi is there any update on this? |
Trying to rebuild zeromq is hell on non-Linux and now that Electron 2.x and 3.x are officially unsupported, using this module (which the whole Python Electron ecosystem depends on) is getting very painful.
The text was updated successfully, but these errors were encountered: